From f856ad543b86bf7ad3ed7f0dfdebe74b6e79633c Mon Sep 17 00:00:00 2001 From: Timo Sirainen Date: Mon, 2 Feb 2026 11:44:58 +0200 Subject: [PATCH] [PATCH] imap-login: Add comments to internal ID command parameter handling Gbp-Pq: Name 0001-imap-login-Add-comments-to-internal-ID-command-param.patch --- src/imap-login/imap-login-cmd-id.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/imap-login/imap-login-cmd-id.c b/src/imap-login/imap-login-cmd-id.c index 2f03282..be12744 100644 --- a/src/imap-login/imap-login-cmd-id.c +++ b/src/imap-login/imap-login-cmd-id.c @@ -183,8 +183,13 @@ static bool cmd_id_handle_keyvalue(struct imap_client *client, imap_id_param_handler_find(key); bool is_login_id_param = handler != NULL; - if (is_login_id_param && client->common.connection_trusted && - !client->id_logged && value != NULL) { + if (!is_login_id_param) { + /* not an internal key */ + } else if (client->id_logged) { + /* using ID multiple times - ignore */ + } else if (value == NULL) { + /* there should have been a value - ignore */ + } else if (client->common.connection_trusted) { if (!handler->callback(client->cmd_id->params, key, value)) { e_debug(client->common.event, "Client sent invalid ID parameter '%s'", key); -- 2.39.5